Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update note about required filters #9298

Merged
merged 2 commits into from
Dec 4, 2024
Merged

docs: update note about required filters #9298

merged 2 commits into from
Dec 4, 2024

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Dec 2, 2024

Description
This PR fixes a note in the user guide about required filters.

Fixes: #9292

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the documentation Pull requests for documentation only label Dec 2, 2024
@michalsn @paulbalandan
Update user_guide_src/source/incoming/filters.rst
40ef26d 
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
@michalsn michalsn merged commit 0d3c3b1 into codeigniter4:develop Dec 4, 2024
4 checks passed
@michalsn
Copy link
Member Author

michalsn commented Dec 4, 2024

Thanks everyone!

@michalsn michalsn deleted the docs/filters branch December 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Route that does not exist (404) does not trigger the 'after' part in required filters
3 participants
@michalsn @kenjis @paulbalandan