Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the namespace option to the publish command #9278

Merged

Conversation

dimtrovich
Copy link

Description
This option allows you to run only Publishers of a specific namespace

The namespace option is used to define the namespace from which to search for publishers. This not only limits the files to be scanned but also prevents a publisher from being reexecuted.
If a library has misconfigured its publisher, reexecution may result in a file being replaced, for example a configuration file of library.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@dimtrovich dimtrovich changed the title added the namespace option to the publish command feat: added the namespace option to the publish command Nov 13, 2024
@ddevsr ddevsr added the wrong branch PRs sent to wrong branch label Nov 14, 2024
@ddevsr
Copy link
Collaborator

ddevsr commented Nov 14, 2024

The new option unaccepted in develop, send to branch 4.6

@dimtrovich dimtrovich changed the base branch from develop to 4.6 November 14, 2024 06:18
@michalsn
Copy link
Member

Please rebase with the 4.6 branch: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#if-you-sent-to-the-wrong-branch

Commits should be signed: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits
We will also need an updated user guide and changelog entry.

@michalsn michalsn added the docs needed Pull requests needing documentation write-ups and/or revisions. label Nov 14, 2024
@michalsn michalsn added enhancement PRs that improve existing functionalities GPG-Signing needed Pull requests that need GPG-Signing 4.6 and removed wrong branch PRs sent to wrong branch labels Nov 14, 2024
@michalsn
Copy link
Member

Your first commit also needs to be signed.

Please add a changelog entry under the Enhancements section: https://github.com/codeigniter4/CodeIgniter4/blob/4.6/user_guide_src/source/changelogs/v4.6.0.rst
A short description is enough.

@michalsn michalsn removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Nov 14, 2024
@dimtrovich dimtrovich force-pushed the namespace-option-to-publisher branch 2 times, most recently from 41e390f to a19437b Compare November 14, 2024 19:41
@michalsn michalsn removed the GPG-Signing needed Pull requests that need GPG-Signing label Nov 14, 2024
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a small fix is needed in the user guide.

user_guide_src/source/libraries/publisher.rst Show resolved Hide resolved
@paulbalandan paulbalandan merged commit bcedf1c into codeigniter4:4.6 Dec 1, 2024
46 checks passed
@paulbalandan
Copy link
Member

Thank you, @dimtrovich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants