chore: Optimize the usage of option 'baseURI' for CURLRequest

[warmbook]

#9265
Description
Use option 'baseURI' first in Config\Services->curlrequest.
Use the property 'uri' of OutgoingRequest as default baseURI instead of the property 'baseURI' of CURLRequest.
Remove the property 'baseURI' of CURLRequest.
Nolonger parse 'baseURI' in 'parseOptions' method.
If 'baseURI' exists in 'request' method's options, create a new URI instance with it. Otherwise, use the property 'uri' of OutgoingRequest.
Use the param '$uri' passed in rather than the property 'baseURI' of CURLRequest in 'prepareURL' method.
Remove 'getBaseURI' method from Test/Mock/MockCURLRequest.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[michalsn]

Just like in your previous PR: removing properties from the class or adding required parameters to the existing methods is considered a BC break.

#9273 (comment)

[warmbook]

@michalsn Emmm... Now that 'there is no need to worry about deprecating anything',why could not us deprecate the property 'baseURI' of CURLRequest?

[michalsn]

@warmbook I was talking about base_uri. The use of base_uri is not documented anywhere, and the switch to camelCase happened before the official v4 release. The use of base_uri is a bug. There is no point in deprecating the bug.

In your code, you're simply removing things without a good reason, which is not acceptable.

[neznaika0]

If you wanted to fix it, all you need to do is replace $options['baseURI'] ?? null

[warmbook]

Thanks! I've got it. But how could I submit the left suggestions? I mean, I have some idea about this framework apart from fixing this bug. @michalsn @neznaika0

[michalsn]

Enhancements and new features can be sent to the 4.6 branch. The develop branch is for bug fixes only.

Just remember that any breaking changes must have a really good reason to be accepted. Backward compatibility is preferred.

[warmbook]

Thanks! I've got it. @michalsn