Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add deprecation error handling for session.sid_length and session.sid_bits_per_character for PHP 8.4 #9135

Closed
wants to merge 1 commit into from
Closed

feat: add deprecation error handling for session.sid_length and session.sid_bits_per_character for PHP 8.4 #9135

wants to merge 1 commit into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 21, 2024

Description
See #9116

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Aug 21, 2024
Open
15 tasks
@kenjis kenjis marked this pull request as draft August 21, 2024 08:23
@kenjis
Copy link
Member Author

kenjis commented Aug 21, 2024

If we don't support PHP 8.4 in v4.5.x, we don't need this PR.

@kenjis kenjis mentioned this pull request Aug 22, 2024
Merged
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Aug 26, 2024

We do not support PHP 8.4 in v4.5.x.

@kenjis kenjis closed this Aug 26, 2024
@kenjis kenjis deleted the add-handling-session.sid_length-deprecation branch August 26, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kenjis