Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PHP 8.4 to test-phpunit.yml #9133

Closed
wants to merge 4 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 21, 2024

Description
See #9116

  • add PHP 8.4 to test-phpunit.yml
  • add --ignore-platform-req=php temporarily to @composer update --working-dir=utils

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Aug 21, 2024
@kenjis kenjis mentioned this pull request Aug 21, 2024
15 tasks
@kenjis
Copy link
Member Author

kenjis commented Aug 21, 2024

Psalm does not work at the moment.

Error: Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - vimeo/psalm[5.0.0, ..., 5.13.1] require php ^7.4 || ~8.0.0 || ~8.1.0 || ~8.2.0 -> your php version (8.4.0-dev) does not satisfy that requirement.
    - vimeo/psalm[5.14.0, ..., 5.25.0] require php ^7.4 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 -> your php version (8.4.0-dev) does not satisfy that requirement.
    - Root composer.json requires vimeo/psalm ^5.0 -> satisfiable by vimeo/psalm[5.0.0, ..., 5.25.0].

Script @composer update --working-dir=utils handling the post-autoload-dump event returned with error code 2
Error: Process completed with exit code 2.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/10481362060/job/29030725682?pr=9133

Error: Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - vimeo/psalm[5.0.0, ..., 5.13.1] require php ^7.4 || ~8.0.0 || ~8.1.0 || ~8.2.0 -> your php version (8.4.0-dev) does not satisfy that requirement.
    - vimeo/psalm[5.14.0, ..., 5.25.0] require php ^7.4 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 -> your php version (8.4.0-dev) does not satisfy that requirement.
    - Root composer.json requires vimeo/psalm ^5.0 -> satisfiable by vimeo/psalm[5.0.0, ..., 5.25.0].

Script @composer update --working-dir=utils handling the post-autoload-dump event returned with error code 2
Error: Process completed with exit code 2.
@kenjis
Copy link
Member Author

kenjis commented Aug 21, 2024

Why doesn't continue-on-error: true work?
Screenshot 2024-08-21 10 33 05

@paulbalandan
Copy link
Member

You should add continue-on-error as part of the workflow step. So, you must add on reusable-phpunit-test.yml

@kenjis kenjis marked this pull request as draft August 21, 2024 23:20
@kenjis
Copy link
Member Author

kenjis commented Aug 26, 2024

We do not support PHP 8.4 in v4.5.x.

@kenjis kenjis closed this Aug 26, 2024
@kenjis kenjis deleted the add-php84-GA-phpunit branch August 26, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants