-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route Names and Vehicle Types #31
Draft
its-all-waves
wants to merge
7
commits into
codefornola:main
Choose a base branch
from
its-all-waves:feat/vehicle-icons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-all-waves
force-pushed
the
feat/vehicle-icons
branch
2 times, most recently
from
December 3, 2024 00:24
24f3650
to
92ede4b
Compare
… all vehicles; add: superimposed markers for arrow (rotates) and vehicle icons; remove: unused 'forwardRef' from 'RotatedMarker'; rename: 'RotatedMarker' -> 'ArrowMarker'; remove: unused icons from ./img
its-all-waves
force-pushed
the
feat/vehicle-icons
branch
from
December 3, 2024 13:58
92ede4b
to
e365fc0
Compare
…; fix: class -> className in main.jsx & modal.jsx
…sed vehicles (those in routes U, PI, PO); add: error icon for vehicles not in service -- should never see due to filtering out unused vehicles, and indicates issue to users and devs; refactor: make vehicleIcon factory func to output any vehicle icon type
its-all-waves
force-pushed
the
feat/vehicle-icons
branch
from
December 4, 2024 22:39
dc491dc
to
ff202a4
Compare
its-all-waves
force-pushed
the
feat/vehicle-icons
branch
from
December 4, 2024 22:45
3f95ae1
to
78d54be
Compare
…act Select Option; rename: 'vehicleTypes' -> 'routeInfo'
its-all-waves
force-pushed
the
feat/vehicle-icons
branch
2 times, most recently
from
December 5, 2024 01:06
d2f4d11
to
d368914
Compare
…der 'RouteOption'
its-all-waves
force-pushed
the
feat/vehicle-icons
branch
from
December 5, 2024 01:06
d368914
to
349a12f
Compare
…replace '>>' with 'to' in marker popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #26.
Icons designed by @HauntedHamburger. (Currently using mock icons.)
Changes