add script to update route geometries programatically and add points for stop locations #19
Conversation
naf419
force-pushed
the
main
branch
2 times, most recently
from
54645c9 to
d935ef4
Compare
see make_routes.sh for source of route/stop info
|
updated for return of #46 rampart streetcar |
|
Looks great! Seems to partially address #23 |
data/make_routes.sh
Outdated
| fi | ||
|
|
||
| #for header just use direction0 to get route name, etc | ||
| cat route_${route}_dir0 | jq '.[0] | {type: "Feature", properties: { agency_name: "NORTA", route_id: .routeCode, agency_id: "1", route_short_name: .routeCode, route_long_name: .routeName, route_type: 3, route_color: ("#" + .routeColor), route_text_color: "#000000" }, geometry: {type: "GeometryCollection", geometries: []}}' > route_${route}_header |
There was a problem hiding this comment.
not sure where this runs- just double checking that we know we have jq available here.
There was a problem hiding this comment.
jq only required to generate routes.json offline.
would replace using QGIS and manual processing which previously generated the routes.json, at least according to https://github.com/codefornola/nola-transit-map/blob/main/data/README.md
There was a problem hiding this comment.
so i picture this would be used to refresh the routes when they change (yearly/whenever) on a single developers system (the only place jq would be required) with the outputs added back into git (so anyone cloning can get the site up easily, no jq required).
(This would be a similar scheme to gnu-style projects that commit the autoconf-generated configure script alongside the autoconf inputs)
naf419
changed the title
naf419
force-pushed
the
main
branch
2 times, most recently
from
3703be6 to
18f7ac0
Compare
|
I still haven't had a chance to review. Some of the folks that are taking over the project are going to look. One thing i do want to note: https://github.com/codefornola/nola-transit-map/pull/19/files#diff-2e26cfed7509767f2d1cd3952d2fa7931097bf6ff9a0e4a704186edd03c52d45 i maybe did this for convenience, but i don't think we should be checking in the built artifact now that this project is public. could be a vector for spam or malware. That doesn't need to be addressed here just bringing it up for the maintainers. |
|
i saw some actual bus stop signs at a #80 stop this afternoon (!) |
I wanted to get yalls thoughts on adding the location of actual bus stops instead of just the route line on the map, and how that might look in the app, so I grabbed the stop data from NORTA (see make_routes.sh for source of route/stop info) and made a quick mockup:
If we could make this look pretty enough to everyone's satisfaction, I think it would be nice to add
fixes #23 and #11