Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatibility for dbt-core v1.6.0 #54

Closed
wants to merge 6 commits into from
Closed

compatibility for dbt-core v1.6.0 #54

wants to merge 6 commits into from

Conversation

tom-juntunen
Copy link
Collaborator

Per the adapter maintainer upgrade guide for v1.6.0, this PR includes the following:

Bugs fixed:

  • Fixed a bug causing the dateadd macro to fail its tests when handling DATETIME type fields. The updated sqlite__dateadd.sql macro now adequately handles both DATE and DATETIME types per ISO-8601 and passes its tests now.

Changes made:

[BtS] Adapter zone tests

  • Added four new tests in test_utils.py and all tests passed without overrides.

No changes required:

[BtS] Drop support for Py 3.7

  • Support for Py 3.7 was already removed in dbt-sqlite 1.2.0rc1.

[BtS] new arg for adapter.execute()

  • We use SQLConnectionManager.execute() directly. No changes required.

No changes made:

[FEATURE] Materialized Views:

  • Materialized views are not supported in sqlite3. No changes made.

[FEATURE] dbt clone

  • Clone objects are not supported in sqlite3 because it is a simple in-process database.

[BtS] revamp of dbt debug

  • No new warnings or errors in tests. No changes made.

Possible remaining todo

  • Left out tests related to Contracts as they aren't being implemented as a feature. I had created a test and ran it only to see the test failed, which was expected, so the unit test needs to be overridden in order to make that passing criteria instead of failing.

tom-juntunen and others added 6 commits April 20, 2024 01:51
@tom-juntunen
add compatiblity for 1.5.0
2a5f0f0 
- sourced from MatthewPocock with a minor adjustment made to the anonymous telemetry `unique_key` to use socket.gethostname()
@tom-juntunen
update sqlite_dateadd to handle datetimes and more dateparts
bd1c175
@tom-juntunen
bump version ref to 1.6.0
76dfc4d 
Remaining todo per upgrade guide:
- stub materialized views (MV) as a materialization option to show users MV are not supported in sqlite
- stub dbt_clone
- add new available tests from 1.6.0 and re-test to find any remaining issues

No action required:
- Support for Python 3.7 is dropped
- debug_query() does not need to be updated, as its not overwritten in our adapter code
- We use SQLConnectionManager.execute() directly; no changes required
@tom-juntunen
switch parameter order for test_dateadd to match typical order
dec62d3
@tom-juntunen
add four new tests in test_utils from dbt-tests-adapter v1.6.0
7cc01b5 
- mention this adapter works with v1.6.x in README
@tom-juntunen
Merge branch 'main' into dbt-1-6-0-compat
2891b45
@tom-juntunen
Copy link
Collaborator Author

Hi @codeforkjeff , here are my proposed updates for dbt-sqlite v1.6.0. Let me know if you'd like anything else here.
I will get to work on v1.7.0 next. We can still plan to deploy both together under 1.7.0 after 1.5.0 is out.

@tom-juntunen
Copy link
Collaborator Author

The commit history got messed up on my end. I'll resubmit a new PR with a simplified history.

@tom-juntunen
Copy link
Collaborator Author

Closing this PR -- new one opened here with a cleaner history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tom-juntunen