-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editable cells #300
base: main
Are you sure you want to change the base?
Editable cells #300
Conversation
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 6982480. |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 suggestions.
Comments skipped due to low confidence (3)
src/views/results/html.ts:185
- The
finishEditing
function does not handle cases whereidValues[i]
is'null'
, potentially leading to an incompleteWHERE
clause. Ensure all necessary conditions are included.
for (let i = 0; i < updateKeyColumns.length; i++) {
src/views/results/resultSetPanelProvider.ts:186
- Declare
currentColumns
withlet
orconst
instead ofvar
.
var currentColumns: html.BasicColumn[]|undefined;
src/views/results/resultSetPanelProvider.ts:181
- Store the result of
Statement.delimName
in a variable to avoid redundancy.
Statement.delimName(schema, true),
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 9eb16b1. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 244b453. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 5f66554. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 77aa0f4. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 888c27f. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 701ced1. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 312de70. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on f443439. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 5fd5d1a. |
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 6fc3713. |
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 14b0c6b. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on c3badb5. |
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 83682da. |
Introducing the
update
prefix. When used in combination with aselect
statement that only references one table, then the cells will become updatable. A fully qualified table must be used.update: select * from schema.table
Tested column types: