Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable cells #300

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Editable cells #300

wants to merge 21 commits into from

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Nov 21, 2024

Introducing the update prefix. When used in combination with a select statement that only references one table, then the cells will become updatable. A fully qualified table must be used.

  • Try using update: select * from schema.table
  • Click on a cell for it to become editable
  • Either click off the cell or use Enter to submit
  • The update is ran as soon as the cell loses focus

Tested column types:

  • Numbers
  • Strings/Chars
  • Date/Times/Timestamp
  • Can set as null

Copy link

👋 A new build is available for this PR based on 6982480.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 suggestions.

Comments skipped due to low confidence (3)

src/views/results/html.ts:185

  • The finishEditing function does not handle cases where idValues[i] is 'null', potentially leading to an incomplete WHERE clause. Ensure all necessary conditions are included.
for (let i = 0; i < updateKeyColumns.length; i++) {

src/views/results/resultSetPanelProvider.ts:186

  • Declare currentColumns with let or const instead of var.
var currentColumns: html.BasicColumn[]|undefined;

src/views/results/resultSetPanelProvider.ts:181

  • Store the result of Statement.delimName in a variable to avoid redundancy.
Statement.delimName(schema, true),

src/views/results/html.ts Outdated Show resolved Hide resolved
src/views/results/html.ts Outdated Show resolved Hide resolved
src/views/results/resultSetPanelProvider.ts Outdated Show resolved Hide resolved
Copy link

👋 A new build is available for this PR based on 9eb16b1.

Copy link

👋 A new build is available for this PR based on 244b453.

Copy link

👋 A new build is available for this PR based on 5f66554.

Signed-off-by: worksofliam <[email protected]>
Copy link

👋 A new build is available for this PR based on 77aa0f4.

Copy link

👋 A new build is available for this PR based on 888c27f.

Copy link

👋 A new build is available for this PR based on 701ced1.

Signed-off-by: worksofliam <[email protected]>
Copy link

👋 A new build is available for this PR based on 312de70.

Copy link

👋 A new build is available for this PR based on f443439.

Signed-off-by: worksofliam <[email protected]>
Copy link

👋 A new build is available for this PR based on 5fd5d1a.

Copy link

👋 A new build is available for this PR based on 6fc3713.

Copy link

👋 A new build is available for this PR based on 14b0c6b.

Copy link

👋 A new build is available for this PR based on c3badb5.

Signed-off-by: worksofliam <[email protected]>
Copy link

👋 A new build is available for this PR based on 83682da.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant