Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry downloading schema and registry data #38

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

tillywoodfield
Copy link
Collaborator

@tillywoodfield tillywoodfield commented Feb 28, 2024

Upgrade iatikit to 3.4.0 to add retries for schema/data downloads.

Closes #37

@odscjames
Copy link
Collaborator

Are there no retries in iatikit? Would it be better to see if we can get something in there, so others users of that can benefit too?

@tillywoodfield
Copy link
Collaborator Author

Are there no retries in iatikit? Would it be better to see if we can get something in there, so others users of that can benefit too?

No there isn't any currently, I can make the change there instead

@tillywoodfield
Copy link
Collaborator Author

@odscjames I've made the change in iatikit (codeforIATI/iatikit#59) and bumped the version to include it here

@tillywoodfield tillywoodfield requested a review from Bjwebb March 6, 2024 15:11
@odscjames
Copy link
Collaborator

Thanks!

To include retry functionality which has been added to download functions

#37
@tillywoodfield tillywoodfield merged commit 39ec6e7 into main Mar 12, 2024
5 checks passed
@tillywoodfield tillywoodfield deleted the add-iatikit-retry branch March 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retry around downloading schema and registry data
2 participants