Skip to content

Commit

Permalink
Don't put colons in error symlink names.
Browse files Browse the repository at this point in the history
It caused in error when trying to use actions/upload-artifact@v4 in
GitHub Actions. It says certain characters are disallowed in order to
maintain compatibility with filesystems like NTFS.

Maybe we should even filter all our on-disk paths to remove this.
According to the error message, they are ":<>|*?\r\n
  • Loading branch information
thomasjm committed Nov 8, 2024
1 parent d00c7a6 commit 860dc43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sandwich/src/Test/Sandwich/Interpreters/StartTree.hs
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ runInAsync node ctx action = do
whenJust baseContextRunRoot $ \runRoot -> do
let symlinkBaseName = case runTreeLoc of
Nothing -> takeFileName dir
Just loc -> [i|#{srcLocFile loc}:#{srcLocStartLine loc}_#{takeFileName dir}|]
Just loc -> [i|#{srcLocFile loc}_line#{srcLocStartLine loc}_#{takeFileName dir}|]
let symlinkPath = errorsDir </> (nodeToFolderName symlinkBaseName 9999999 runTreeId)

-- Delete the symlink if it's already present. This can happen when re-running
Expand Down

0 comments on commit 860dc43

Please sign in to comment.