Generate GenerateAutomaticInterfaceAttribute #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 16, 2024 11:47
ChristianSauer
requested changes
Apr 16, 2024
….com/crwsolutions/net_automatic_interface into feature/generate-interface-attribute
|
Just to dust off this PR :): Hi, I've added a step in the README, to add the using statement. So if you are happy with it this can be merged now in my opinion. But it is also possible to remove the namespace for some extra convenience (would be mine preference). I would also like to highlight in that case, that the generated Attribute is internal. So the probability of conflicts is really about zero. |
|
Any chance that this gets merged and released in a foreseeable time frame @ChristianSauer? I would really like to start working on some new features (like custom interface name and get only properties in interfaces), but I consider this a prerequisite. |
|
@ccHanibal @crwsolutions I've finally merged it. Sorry, where a shitty few months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate GenerateAutomaticInterfaceAttribute instead of asking that of the user.
See cookbook:
https://github.com/dotnet/roslyn/blob/main/docs/features/incremental-generators.cookbook.md#generated-class
If you're feeling adventurous, it is possible to remove the namespace from the generated attribute (so remove 'namespace AutomaticInterface'). That would give even more convenience. Given the name of the attribute I think there is very little change of type conflicts.