Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle boolean default values correctly #40

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Handle boolean default values correctly #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AutomaticInterface/AutomaticInterface/Builder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ private static string GetMethodSignature(IParameterSymbol x)
var optionalValue = x.ExplicitDefaultValue switch
{
string => $" = \"{x.ExplicitDefaultValue}\"",
bool value => $" = {(value ? "true" : "false")}",
// struct
null when x.Type.IsValueType => $" = default({x.Type})",
null => " = null",
Expand Down
9 changes: 5 additions & 4 deletions AutomaticInterface/Tests/GeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ public class DemoClass
public bool TryStartTransaction(
string file = "",
string member = "",
int line = 0)
int line = 0,
bool notify = true)
{
return true;
}
Expand All @@ -82,7 +83,7 @@ namespace AutomaticInterfaceExample
public partial interface IDemoClass
{
/// <inheritdoc />
bool TryStartTransaction(string file = "", string member = "", int line = 0);
bool TryStartTransaction(string file = "", string member = "", int line = 0, bool notify = true);

}
}
Expand Down Expand Up @@ -1885,7 +1886,7 @@ namespace AutomaticInterfaceExample
public partial interface IDemoClass
{
/// <inheritdoc />
Task<Stream?> GetFinalDocumentsByIDFails(string agreementID, string docType, bool amt = False, bool? attachSupportingDocuments = True, CancellationToken cancellationToken = null);
Task<Stream?> GetFinalDocumentsByIDFails(string agreementID, string docType, bool amt = false, bool? attachSupportingDocuments = true, CancellationToken cancellationToken = null);

}
}
Expand Down Expand Up @@ -1957,7 +1958,7 @@ namespace CustomNameSpace
public partial interface IDemoClass
{
/// <inheritdoc />
Task<Stream?> GetFinalDocumentsByIDFails(string agreementID, string docType, bool amt = False, bool? attachSupportingDocuments = True, CancellationToken cancellationToken = null);
Task<Stream?> GetFinalDocumentsByIDFails(string agreementID, string docType, bool amt = false, bool? attachSupportingDocuments = true, CancellationToken cancellationToken = null);

}
}
Expand Down
Loading