implement filtered list #120
Conversation
adaczo
requested review from
aniri,
catileptic,
moonflare,
RaduCStefanescu,
RazvanCiuca and
Utwo
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/code4ro/taskforce-fe-components/n2n79imge |
| import "./filtered-list-item.styles.scss"; | ||
| import CaretSvg from "../../../images/icons/caret.svg"; | ||
|
|
||
| export class FilteredListItem extends React.Component { |
There was a problem hiding this comment.
All components in here are function components. For the sake of consistency, could you please convert yours to function components as well?
There was a problem hiding this comment.
Refactored FilteredListItem to use a function.
@surdu For FilteredList I need to have local state, do you recommend a different approach?
src/components/filtered-list/filtered-list-item/filtered-list-item.styles.scss
Show resolved
Hide resolved
Talked with @RaduCStefanescu and decided to seperate that ticket into 2 smaller reusable components that is api agnostic and reusable in different places. This PR addresses the list component. |
|
Heya! I talked to @adaczo privately and we decided we needed some small changes to this component, so he started from scratch. |
| }; | ||
|
|
||
| FilteredList.propTypes = { | ||
| config: PropTypes.object, |
There was a problem hiding this comment.
I believe it will be better if we define this as a PropTypes.shape. Please see here for an example.
What changed?