Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/project stack #527

Merged
merged 18 commits into from
Oct 21, 2024
Merged

Conversation

CuriousCoder00
Copy link
Contributor

@CuriousCoder00 CuriousCoder00 commented Oct 20, 2024

Fixes: #522 #526

demo.mp4

@CuriousCoder00
Copy link
Contributor Author

@VineeTagarwaL-code review please
and may i start working on #522 in this pr?

@CuriousCoder00
Copy link
Contributor Author

CuriousCoder00 commented Oct 20, 2024

demo2.mp4

@CuriousCoder00
Copy link
Contributor Author

@VineeTagarwaL-code please review the PR and tell me if there are any improvements/changes needed

@VineeTagarwaL-code
Copy link
Collaborator

Lessss goooooooo !!!!!

@VineeTagarwaL-code
Copy link
Collaborator

Loved the showcase, reviewing give me a minute

prisma/schema.prisma Outdated Show resolved Hide resolved
src/components/profile/UserProject.tsx Outdated Show resolved Hide resolved
@CuriousCoder00
Copy link
Contributor Author

@VineeTagarwaL-code Got it.. making the changes in few mins

@CuriousCoder00
Copy link
Contributor Author

CuriousCoder00 commented Oct 21, 2024

image
Made the required changes
Additionally added spinner while projects are being fetched and in case for no projects showing messsage No projects found

@CuriousCoder00
Copy link
Contributor Author

Refactored code for experience showcase
Before:
image

After:
image

@CuriousCoder00
Copy link
Contributor Author

  • Implemented Add more button in Projects, Experiences, Skills

Should i add extra functionalities such as:

  • Allowing user to edit projects/experiences/skillsets details
  • Allowing user to delete as well

@VineeTagarwaL-code VineeTagarwaL-code self-requested a review October 21, 2024 14:33
@VineeTagarwaL-code VineeTagarwaL-code merged commit eb7fdc8 into code100x:main Oct 21, 2024
1 check passed
@VineeTagarwaL-code
Copy link
Collaborator

Noice work man, do dm me in discord once i will put you up in bounty list

also make sure you post on x to catch good eyes of recruiters, OS helps a lot ! <3

@CuriousCoder00
Copy link
Contributor Author

Noice work man, do dm me in discord once i will put you up in bounty list

also make sure you post on x to catch good eyes of recruiters, OS helps a lot ! <3

@VineeTagarwaL-code
I appriciate your kind words, i'll dm you on discord soon and will tag you and kirat bhaiya when i post on x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Stack based project listing
2 participants