Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added twitter testimonials in place of dummy ones #405

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

vatan45
Copy link
Contributor

@vatan45 vatan45 commented Sep 25, 2024

issue no- #396
BEFORE:-

Screenshot 2024-09-25 at 11 18 03 AM

AFTER:-
Screenshot 2024-09-25 at 1 35 55 PM

the testimonials are scrollable so that user can see all of them and it doesnot take much space too on the page

added the tweets of 100xdevs , success stories

@VineeTagarwaL-code
Copy link
Collaborator

a good pr , get redis of blur sides, and arrow, keep auto scrolling and also allow user to scroll both directions

@vatan45
Copy link
Contributor Author

vatan45 commented Sep 25, 2024

a good pr , get redis of blur sides, and arrow, keep auto scrolling and also allow user to scroll both directions

go it , on it

@vatan45
Copy link
Contributor Author

vatan45 commented Sep 26, 2024

@VineeTagarwaL-code

WhatsApp.Video.2024-09-26.at.11.24.07.mp4
  • Blur side removed
  • Arrows removed
  • Auto scrolling enabled
  • Need assistance with enabling left and right scrolling without arrow keys.

@aakash2330
Copy link
Contributor

aakash2330 commented Sep 27, 2024

Screenshot 2024-09-27 at 1 00 16 PM

  1. can you make it take more space on bigger screens
  2. the height of the first card in ss is different from the height in 2nd and third , can you give it some min height so it stays consistent .
    3 . There carousel when finishes reverses itself , that too in a different speed , can you make it infinite
Screen.Recording.2024-09-27.at.1.04.24.PM.mov
  1. It should also stop on hover in case someone want to stop and watch a video .
  2. remove unnecessary empty lines for better readibility .

@vatan45
Copy link
Contributor Author

vatan45 commented Sep 27, 2024

Screenshot 2024-09-27 at 1 00 16 PM

  1. can you make it take more space on bigger screens
  2. the height of the first card in ss is different from the height in 2nd and third , can you give it some min height so it stays consistent .
    3 . There carousel when finishes reverses itself , that too in a different speed , can you make it infinite

Screen.Recording.2024-09-27.at.1.04.24.PM.mov
4. It should also stop on hover in case someone want to stop and watch a video .
5. remove unnecessary empty lines for better readibility .

sure , on it

@vatan45
Copy link
Contributor Author

vatan45 commented Sep 27, 2024

  • Set a Minimum Height for the First Card
  • Make the Carousel Infinite
  • Pause Carousel on Hover
  • Improve Code Readability
    @VineeTagarwaL-code done with more changes

@vatan45
Copy link
Contributor Author

vatan45 commented Oct 1, 2024

@VineeTagarwaL-code @hkirat review please...

@VineeTagarwaL-code VineeTagarwaL-code merged commit 1d5f254 into code100x:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants