Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:added some validation #358

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

Paribesh01
Copy link
Contributor

@Paribesh01 Paribesh01 commented Sep 17, 2024

Screenshot 2024-09-17 231749
Screenshot 2024-09-17 231814

added red box when field are empty
and centered the post button

Screen.Recording.2024-09-17.235257.mp4

@VineeTagarwaL-code
Copy link
Collaborator

can you give a video to ref your changes ?

@Paribesh01
Copy link
Contributor Author

@VineeTagarwaL-code done

@VineeTagarwaL-code
Copy link
Collaborator

reviewing and testing now

@VineeTagarwaL-code
Copy link
Collaborator

this doesnt give the error message, please add that so i can merge

@Paribesh01
Copy link
Contributor Author

Screenshot 2024-09-21 142144
added error message

@VineeTagarwaL-code
Copy link
Collaborator

the red color is not so visible, can you improve over that ?

@Paribesh01
Copy link
Contributor Author

Screenshot 2024-09-21 145931
@VineeTagarwaL-code done

@VineeTagarwaL-code VineeTagarwaL-code merged commit 00176e5 into code100x:main Sep 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants