reset all filters functionality added #236 #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also make sure that the results reset too , it's not very ui friendly if the user have to also click on apply after resetting |
Noted and Completed! ✅ Screen.Recording.2024-08-23.at.08.12.47.mov |
|
nice this is good |
|
the workflow fails + doesn't updates the url |
|
I forget to commit the latest modification, I guess it's fine after 92e7a2e commit. @VineeTagarwaL-code |
2 tasks
|
fix the conflicts will merge |
Done ✅ |
aakash2330
reviewed
Sep 4, 2024
| @@ -41,27 +41,39 @@ const JobFilters = ({ searchParams }: { searchParams: JobQuerySchemaType }) => { | |||
| }, | |||
| }); | |||
|
|
|||
| const formValues = form.watch(); | |||
| async function handleFormSubmit(data: JobQuerySchemaType) { | |||
| await jobFilterQuery( | |||
There was a problem hiding this comment.
please use the new setQueryParams hook , or if you're just resetting the page you can just reload the page without query params , something like router.replace(pathname);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves the issue #236 as there is no functionality of "Reset all filter" in Filters sections of View Jobs page.
Screen.Recording.2024-08-20.at.01.32.31.mov