Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin functionality issue in the comment dropdown menu #880

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

vijaysingh2219
Copy link
Contributor

PR Fixes: #877

  • Fixed the issue where the pin functionality was partially working in the dropdown menu of individual comment.

Resolves #877

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@vijaysingh2219
Copy link
Contributor Author

Hi @hkirat, The issue with the functionality was that a partial area of the dropdown menu item's width was occupied by the form and button. This PR ensures that the entire area of the dropdown menu item is occupied by the form, making the pin functionality work correctly.

Before:
Screenshot 2024-08-12 131311

After:
Screenshot 2024-08-12 131619

@amanbairagi30
Copy link
Contributor

you forgot to fix copy button item

@vijaysingh2219
Copy link
Contributor Author

you forgot to fix copy button item

Thanks for catching that, I’ve fixed the copy button item.

@siinghd
Copy link
Collaborator

siinghd commented Aug 14, 2024

Thank you @vijaysingh2219

@siinghd siinghd merged commit 3747c41 into code100x:main Aug 14, 2024
1 check passed
@vijaysingh2219 vijaysingh2219 deleted the fix/pin-functionality branch August 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: pin functionality is not working
3 participants