-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: added comments, added people can comment chapters, some improvements #80
Conversation
@siinghd is attempting to deploy a commit to the My Team Team on Vercel. A member of the Team first needs to authorize it. |
@hkirat can you look at this? would like to merge and do the admin part/some improvements |
Wow, beautiful |
Now admin can also approve the intro comments preview: screen-recording-2024-02-09-at-113953-pm_pOzDYbbd.mp4 |
Beautiful |
/bounty $400 |
Can u try deploying this to a local vercel @siinghd ? |
@hkirat Was about to ping you, saw the deploy failed... let me do it now :) Thanks for the bounty veere <3 |
@hkirat let me look at it |
Just need to migrate the DB I think I can figure this out @siinghd |
@hkirat any update on this? |
Build: Working on local
Features:
Comments: users can comment under the video/notion
Replies: Users can reply to a comment (Allowed only to depth 1 like youtube)
Upvotes/downvote: user can upvote or downvote the comment
Comment as chapter: user can comment chapters following the current format:
This is fully working and the comment is inserted as type
INTRO
and with flag approved to false.Note*: In this PR admin part is not included but i was thinking to add a accept button or dropdown option where the admin can accept it. Second option would be to copy the comment id and on admin part make a input with comment id,adminpassword and approve button.
On accepted the comment will be transformed to reflect the segments array and saved, the function to do it is already present thank to CHATGPT :)
Also user can click the timestamp in the comments and the video timestamp will be set to that.
Missing:
Admin part to accept the chapter comment
Admin can delete any comment
Users update/delete their comment
This is what i remember, ill update this if get to remember something else.
Improvemnts:
Many ui related improvement can be done
Maybe use react query for infinite scroll and remove current pagination
preview
2024-02-08-00-19-52_qW58um8W.mp4