Dyanmic thumbnails generated according to the title of the video , notion , folder(current week) #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
very cool PR |
hkirat
reviewed
Jun 16, 2024
| @@ -95,11 +95,7 @@ export const CertificateComponent = ({ | |||
| </Button> | |||
| <div className="flex items-center justify-center"> | |||
| <Button | |||
| <<<<<<< tailwind-prettier | |||
There was a problem hiding this comment.
where did this get in?
@siinghd
There was a problem hiding this comment.
It was a merge conflit so I have allowed a incoming one
Thanks @hkirat if the PR eligible for bounty could you please mention that for motivation purpose |
|
testing it RIght now |
|
Merging, you will get the bounty for sure |
Thank you @siinghd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Resolves #790 .
Here are the proofs of how this works and my design , I am providing both the screenshots as well as screencast so in screencast you can able to see the responsiveness of the card component
screenshot of how video and notion looks like
screenshot of how folder looks like
screencast of all together with mobile responsiveness has been shown here
Screencast from 2024-06-16 00-08-27.webm
Checklist before requesting a review