feat: Add fallback to Bunny URLs if main URLs are not accessible

[TanmayDhobale]

PR Fixes: #776

This PR adds a new feature to the ContentRenderer component that checks if the main video URLs from the database are accessible or not. If any of the main URLs are not accessible, it falls back to using the Bunny URLs instead.

Changes:

1. Added a new helper function isUrlAccessible that makes a HEAD request to a given URL and returns a boolean indicating whether the URL is accessible or not.

2. Modified the getMetadata function:

   • If the user.bunnyProxyEnabled flag is true, it returns the Bunny URLs directly.
   • If bunnyProxyEnabled is false, it creates an object mainUrls containing the main URLs from the database.
   • It then uses Promise.all and the isUrlAccessible function to check if all the main URLs are accessible.
   • If all main URLs are accessible, it returns mainUrls.
   • If any of the main URLs is not accessible, it returns the Bunny URLs instead.

This change ensures that if the main video URLs are not accessible for any reason, the application falls back to using the Bunny URLs, providing a more reliable experience for users.

Checklist before requesting a review

• I have performed a self-review of my code
• I assure there is no similar/duplicate pull request regarding same issue

[TanmayDhobale]

@hkirat This approach is right ? like rn it makes HEAD requests to all the main URLs, which could potentially cause performance issues if there are many URLs to check Instead of checking the accessibility of all main URLs (1080p, 720p, and 360p) by making individual HEAD requests for each URL we can only checks the accessibility of the highest quality video URL (1080p).

[siinghd]

@hkirat This approach is right ? like rn it makes HEAD requests to all the main URLs, which could potentially cause performance issues if there are many URLs to check Instead of checking the accessibility of all main URLs (1080p, 720p, and 360p) by making individual HEAD requests for each URL we can only checks the accessibility of the highest quality video URL (1080p).

This should work fine, but can you implement a fallback mechanism that attempts to check other urls only if necessary?

what i mean is:

1- check the highest quality url first, if available return mainurls if not
2- check for 720 and 360, if 720 available return mainurls, if not check for 360, if 360 available return mainurls else return bunnyurls

[TanmayDhobale]

@hkirat This approach is right ? like rn it makes HEAD requests to all the main URLs, which could potentially cause performance issues if there are many URLs to check Instead of checking the accessibility of all main URLs (1080p, 720p, and 360p) by making individual HEAD requests for each URL we can only checks the accessibility of the highest quality video URL (1080p).

This should work fine, but can you implement a fallback mechanism that attempts to check other urls only if necessary?

what i mean is:

1- check the highest quality url first, if available return mainurls if not
2- check for 720 and 360, if 720 available return mainurls, if not check for 360, if 360 available return mainurls else return bunnyurls

Yeah sure, let me do that. ( We got a new maintainer before GTA 6)

[TanmayDhobale]

@siinghd done

[siinghd]

@TanmayDhobale

still the same thing

here:

if (user.bunnyProxyEnabled) {
    return {
      1080: bunnyUrl(metadata[`video_1080p_mp4_${userId}`]),
      720: bunnyUrl(metadata[`video_720p_mp4_${userId}`]),
      360: bunnyUrl(metadata[`video_360p_mp4_${userId}`]),
      subtitles: metadata['subtitles'],
      slides: metadata['slides'],
      segments: metadata['segments'],
      thumbnails: metadata['thumbnail_mosiac_url'],
    };
  }
  
  this is duplicate

{
1080: bunnyUrl(metadata[video_1080p_mp4_${userId}]),
720: bunnyUrl(metadata[video_720p_mp4_${userId}]),
360: bunnyUrl(metadata[video_360p_mp4_${userId}]),
subtitles: metadata['subtitles'],
slides: metadata['slides'],
segments: metadata['segments'],
thumbnails: metadata['thumbnail_mosiac_url'],
};

[siinghd]

Move const bunnyUrls = {

above

if (user.bunnyProxyEnabled) {
    return {
      1080: bunnyUrl(metadata[`video_1080p_mp4_${userId}`]),
      720: bunnyUrl(metadata[`video_720p_mp4_${userId}`]),
      360: bunnyUrl(metadata[`video_360p_mp4_${userId}`]),
      subtitles: metadata['subtitles'],
      slides: metadata['slides'],
      segments: metadata['segments'],
      thumbnails: metadata['thumbnail_mosiac_url'],
    };
  }
  
  and do 
  
  if (user.bunnyProxyEnabled) {
    return bunnyUrls
  }

[TanmayDhobale]

@siinghd

[siinghd]

Merging Thank you, will submit this pr, if it will satisfy bounty requirements, you will get it

[TanmayDhobale]

Merging Thank you, will submit this pr, if it will satisfy bounty requirements, you will get it

sure 👍

[hkirat]

/bounty $30