-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/user progress #64
Conversation
@nimit9 is attempting to deploy a commit to the My Team Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, everything else looks perfect
@@ -7,7 +7,43 @@ const APPX_BASE_API = process.env.APPX_BASE_API; | |||
const LOCAL_CMS_PROVIDER = process.env.LOCAL_CMS_PROVIDER; | |||
|
|||
export async function getPurchases(email: string) { | |||
const courses = await db.course.findMany({}); | |||
const _courses = await db.course.findMany({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this assume that videos will only be at a depth
of 1
? Not a problem right now but could be in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it could be a problem, let me check how to fix it.
@@ -81,7 +81,11 @@ async function getAllContent() { | |||
if (value) { | |||
return value; | |||
} | |||
const allContent = await db.content.findMany({}); | |||
const allContent = await db.content.findMany({ | |||
include: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is prolly incorrect. videoProgress is user specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, will fix this as well
This was a great PR but had some issues I fixed in master. |
Hey @hkirat, Thanks a lot. ebe0ac7 is this the commit that you're talking about? Also, I was going to work on the issues you had mentioned, but have been sick for some days. I think you've made those changes in the PR (glanced at it from mobile, will check it thoroughly in the morning from the laptop) |
#2:
Screencast from 2024-02-03 18-01-59.webm
Screencast from 2024-02-03 18-05-37.webm
Also fixed #60