Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/user progress #64

Merged
merged 4 commits into from
Feb 4, 2024
Merged

Feat/user progress #64

merged 4 commits into from
Feb 4, 2024

Conversation

nimit9
Copy link
Contributor

@nimit9 nimit9 commented Feb 3, 2024

#2:

  • Added option of marking video as complete and incomplete
  • Showing progress percentage on course card and content card
  • Showing tick mark on ContentCard if video is marked as complete

Screencast from 2024-02-03 18-01-59.webm
Screencast from 2024-02-03 18-05-37.webm

Also fixed #60

Copy link

vercel bot commented Feb 3, 2024

@nimit9 is attempting to deploy a commit to the My Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@hkirat hkirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, everything else looks perfect

@@ -7,7 +7,43 @@ const APPX_BASE_API = process.env.APPX_BASE_API;
const LOCAL_CMS_PROVIDER = process.env.LOCAL_CMS_PROVIDER;

export async function getPurchases(email: string) {
const courses = await db.course.findMany({});
const _courses = await db.course.findMany({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this assume that videos will only be at a depth of 1 ? Not a problem right now but could be in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it could be a problem, let me check how to fix it.

@hkirat hkirat merged commit d70659f into code100x:main Feb 4, 2024
0 of 2 checks passed
@@ -81,7 +81,11 @@ async function getAllContent() {
if (value) {
return value;
}
const allContent = await db.content.findMany({});
const allContent = await db.content.findMany({
include: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is prolly incorrect. videoProgress is user specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, will fix this as well

@hkirat
Copy link
Contributor

hkirat commented Feb 6, 2024

This was a great PR but had some issues I fixed in master.
/bounty $75 for the effort, would be great if you can check out the fixes I made in master

@nimit9
Copy link
Contributor Author

nimit9 commented Feb 7, 2024

Hey @hkirat, Thanks a lot.

ebe0ac7 is this the commit that you're talking about?

Also, I was going to work on the issues you had mentioned, but have been sick for some days. I think you've made those changes in the PR (glanced at it from mobile, will check it thoroughly in the morning from the laptop)

@nimit9 nimit9 deleted the feat/user-progress branch February 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Chapters button is not showing video chapters on clicking
2 participants