Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto seeding video duration to database without manual intervention #614

Closed
wants to merge 1 commit into from

Conversation

mvp5464
Copy link
Contributor

@mvp5464 mvp5464 commented May 13, 2024

PR Fixes:

  • 1 If video duration is empty, and anyone clicks on that video, It adds video duration to the database
  • 2 Video thumbnail will have proper duration

Resolves #485

Old PR #486 #558 : Closed because of many merge conflict other problems

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

1> Need to seed every-time when uploading a video

2> Week-9 is seeded but Week-10 is not seeded

Screenshot1

Screenshot2

Approach

Screencast.from.23-04-24.01.51.18.PM.IST.webm

@siinghd
Copy link
Collaborator

siinghd commented Jun 25, 2024

@mvp5464 , the video duration should be added actually from the backend while posting the video... this seems little forced idk how to explain it

@mvp5464
Copy link
Contributor Author

mvp5464 commented Jun 25, 2024

@mvp5464 , the video duration should be added actually from the backend while posting the video... this seems little forced idk how to explain it

Yes @siinghd sir, so should I create pr to add the duration when the video is uploaded (also suggested in comment in this #558 pr)

@mvp5464 mvp5464 closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Show video duration to the thumbnail instead of 0
2 participants