Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed time line for videos with no segments #604

Conversation

mumin-khan
Copy link
Contributor

@mumin-khan mumin-khan commented May 13, 2024

PR Fixes:

  • 1 No timeline for videos without segments
  • 2
    Reverted to the new video controls and Fixed errors in it. Removed redundant code and added functionality to skip back and forward by double clicking which was missing in new video controls.
    Resolves bug: seekbar doesnt appear if there are no segments #584

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@mumin-khan
Copy link
Contributor Author

image

@nimit9
Copy link
Contributor

nimit9 commented May 13, 2024

Please remove console logs.

Also, This seems like a hacky way of doing it.
Try not to show the segments at all if there are no segments, and just show the seekbar.

@mumin-khan
Copy link
Contributor Author

mumin-khan commented May 13, 2024

Please remove console logs.

Also, This seems like a hacky way of doing it. Try not to show the segments at all if there are no segments, and just show the seekbar.

I am not showing segments.
Will have to do a lot refractoring as timeline are constructed based on segments only.

@nimit9
Copy link
Contributor

nimit9 commented May 13, 2024

I am not showing segments.

I meant you're still making changes in the segment array

@mumin-khan
Copy link
Contributor Author

mumin-khan commented May 13, 2024

I am not showing segments.

I meant you're still making changes in the segment array

I agree this is somewhat hacky.
But as I said the code is is in such a way that there is no seekbar timelines are created for each segment with width equal to duration and events are registered for it.

P.S : I am making changes to segments only in a function only. It's kind of local to that that's why segments comp on right and other things related to them don't appear. And thanks for taking timeout to do the review.

@siinghd
Copy link
Collaborator

siinghd commented Jul 6, 2024

reopen, there are many conflicts

@siinghd siinghd closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: seekbar doesnt appear if there are no segments
3 participants