added next prev feature #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkirat
reviewed
May 12, 2024
| }) => { | ||
| const metadata = await getMetadata(content.id); | ||
|
|
||
| const prevNextUrls = await getNextPrevUrls(content.id, courseId); |
There was a problem hiding this comment.
dont do this here asynchronously. Thisll delay rendering until this is fetched, and this isnt needed for most renders
Do it in an effect maybe?
There was a problem hiding this comment.
sir using cached values instead of database fetches.
please do check the last file ./db/course.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Resolves #559
output
Checklist before requesting a review