[Bugfix] Workflow Fix #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahil Suman <[email protected]>
|
@sahilsuman933 is attempting to deploy a commit to the My Team Team on Vercel. A member of the Team first needs to authorize it. |
|
@hkirat, you can now merge this PR. After it's merged, I'll create another PR to resolve all the formatting issues. |
|
This will require a wholesale lint |
|
Okay, @hkirat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19 #23
This PR addresses three issues:
The requirement is to run the workflow on each pull request made to this repository. To achieve this, we need to use the push trigger instead of pull_request.
It resolves several conflicts between eslint and prettier.
a. It changes single quotes to double quotes.
b. The eslint indentation check is removed as prettier and eslint indent do not work together due to differing indentation styles. Reference: https://stackoverflow.com/questions/56337176/prettier-and-eslint-indents-not-working-together
c. Removed unnecessary semicolon.