Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixes]/ 370: Navbar responsiveness #375

Closed

Conversation

pkmanas22
Copy link
Contributor

PR Fixes:

Resolves #370

  • Just changed the searchbar from md to lg

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@pkmanas22
Copy link
Contributor Author

Okay bro, I think u just create issue, so i try to solve it. By the way please don't wait for assign, If u solved then u can directly create a PR or specify that u r working on it, then it should be best. In open source, start working in it without waiting for assign. Here we all r looking to small small contributions. But in big project there is competition.

My suggestion is create your pr, and the best pr should be merged.
I just replaced 2 words in my pr, so create a best one.

@noobpiyush
Copy link
Contributor

@

Okay bro, I think u just create issue, so i try to solve it. By the way please don't wait for assign, If u solved then u can directly create a PR or specify that u r working on it, then it should be best. In open source, start working in it without waiting for assign. Here we all r looking to small small contributions. But in big project there is competition.

My suggestion is create your pr, and the best pr should be merged. I just replaced 2 words in my pr, so create a best one.

my suggestion is that you first take permission then create a pull req or create your issue then make a pull req. i had created a pull req that was not reviewed

@pkmanas22
Copy link
Contributor Author

okay bro, don't fight for this, I close my issue, don't worry

@pkmanas22 pkmanas22 closed this Apr 13, 2024
@pkmanas22 pkmanas22 deleted the fix-370-appbar-responsiveness branch September 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: NAV-BAR is not responsive between 786px to 1122px viewport width.
2 participants