Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOL] Arrow keys don't work after toggling the Fullscreen unless clicked on the video again. #262 #301

Merged
merged 1 commit into from
Apr 1, 2024
Merged

[SOL] Arrow keys don't work after toggling the Fullscreen unless clicked on the video again. #262 #301

merged 1 commit into from
Apr 1, 2024

Conversation

Deepak1649
Copy link
Contributor

PR Fixes:

    1. This issue just needed to get the focus back to video after user toggle Fullscreen button.
    1. It was quite irritating to click on the screen every time while changing tabs to control the video.

Resolves #262

Checklist before requesting a review

  • [Y] I have performed a self-review of my code
  • [Y] I assure there is no similar/duplicate pull request regarding same issue

Before Fixing the issue:

New.Project.-.Made.with.Clipchamp.1.mp4

After Fixing the issue:

20240331_162826.-.Trim.mp4

@hkirat hkirat merged commit 219fb7d into code100x:main Apr 1, 2024
1 check passed
@hkirat
Copy link
Contributor

hkirat commented Apr 1, 2024

/bounty $10

@Deepak1649
Copy link
Contributor Author

Thankyou :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrow keys don't work after toggling the Fullscreen unless clicked on the video again.
2 participants
@Deepak1649 @hkirat