Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: downloading notes #286

Merged
merged 2 commits into from
Mar 28, 2024
Merged

feat: downloading notes #286

merged 2 commits into from
Mar 28, 2024

Conversation

nimit9
Copy link
Contributor

@nimit9 nimit9 commented Mar 28, 2024

Feat #285 - Add a download button to notes

Had to modify css in the printing page for the printed document to look decent.

Screencast.from.2024-03-29.01-40-41.webm
Screencast.from.2024-03-29.01-39-18.webm

@nimit9 nimit9 changed the title feat: printing notion notes feat: downloading notes Mar 28, 2024
@devsargam
Copy link
Collaborator

hey @nimit9
I think this is much optimized and elegant solution for print
https://tailwindcss.com/docs/hover-focus-and-other-states#print-styles

@nimit9
Copy link
Contributor Author

nimit9 commented Mar 28, 2024

Hey @devsargam , because I'm modifying notion classes, will have to add it with JS
Will add the print classes on appbar and footer

Thanks for the suggestion!

@hkirat
Copy link
Contributor

hkirat commented Mar 28, 2024

/bounty $50

@hkirat hkirat merged commit c90b67f into code100x:main Mar 28, 2024
1 check passed
@nimit9 nimit9 deleted the feat/notes-download branch March 28, 2024 21:02
@nimit9
Copy link
Contributor Author

nimit9 commented Mar 28, 2024

Thank you ser 🫡🫡 @hkirat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants