Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bookmarks #237

Closed
wants to merge 6 commits into from
Closed

Feat/bookmarks #237

wants to merge 6 commits into from

Conversation

nimit9
Copy link
Contributor

@nimit9 nimit9 commented Mar 18, 2024

Also added missed migration by @siinghd in #170

Added Bookmark Feature #4

Screencast.from.2024-03-18.05-39-59.webm

P.S: This assumes that the video will be added to the folder directly and there would be no nested folders.

More features to be added

  • Marking bookmarks as favorite
  • Pagination on bookmark page
  • Filtering bookmakrs based on video
  • Some UI changes

@hkirat, if there is a scene of nested folders, I have a solution for that, but that is complicated and requires to make nested db calls to get the parent ids (folders) of the video. I have somewhat completed code for that as well, so can work on that quickly if needed.
In that case, UI would look something like this:
Screenshot from 2024-03-17 01-22-36

@nimit9 nimit9 mentioned this pull request Mar 18, 2024
@hkirat
Copy link
Contributor

hkirat commented Mar 18, 2024

So, I dont think we need this
We do need a way for people to mark videos as favourite/bookmark them
But bookmarking a timestamp seems over engineered/dont think anyone would use it
Closing for now, but feel free to re-open

@hkirat hkirat closed this Mar 18, 2024
@nimit9
Copy link
Contributor Author

nimit9 commented Mar 18, 2024

Okay, then I'll do the same thing with videos instead of the timestamp.
please assign the issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants