Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Integrate Code Quality Tools for Enhanced Consistency #211

Closed
wants to merge 0 commits into from

Conversation

TanmayDhobale
Copy link
Contributor

This pull request introduces ESLint, Prettier, and Husky into our development workflow. The integration of these tools serves to enforce a consistent coding standard across the project, ensuring that all contributions adhere to our defined styles and practices.

Key Changes:

  • ESLint: Setup to analyze the codebase for adherence to our coding standards, helping identify potential errors and code smells.
  • Prettier: Configured to automatically format code according to our specified styles, ensuring consistency in the appearance and structure of our code.
  • Husky: Employed to trigger ESLint and Prettier checks before committing changes, ensuring that only code that meets our quality standards is added to the repository.

These tools collectively contribute to a more maintainable and error-free codebase, streamlining the development process and enhancing collaboration efficiency.

@TanmayDhobale
Copy link
Contributor Author

@hkirat this is right approach ?

@devsargam
Copy link
Collaborator

I might be wrong but we do alreay have husky, eslint and prettier

@TanmayDhobale
Copy link
Contributor Author

@devsargam We've updated and fine-tuned our existing Husky, ESLint, and Prettier configurations to enhance code consistency and automation further

@adexh
Copy link
Contributor

adexh commented Mar 12, 2024

With so many files touched, its difficult to review the changes which are done particularly for this PR.

@TanmayDhobale
Copy link
Contributor Author

@adexh This PR mainly updates our ESLint, Prettier, and Husky setups. Most changes are automatic formatting, so please focus on the config updates

@devsargam
Copy link
Collaborator

Linting can be a separate pr actually

@TanmayDhobale
Copy link
Contributor Author

@devsargam umm ???

@devsargam
Copy link
Collaborator

I mean a lot of files have been changed which makes ur pr hard to review. Can u revert all the linted files and only focus on what was changed actually?

@TanmayDhobale
Copy link
Contributor Author

Most changes are automatic formatting !!!!

@TanmayDhobale
Copy link
Contributor Author

TanmayDhobale commented Mar 12, 2024

lets see I'll revert the formatting changes in the linted files to highlight the key updates made to our ESLint, Prettier, and Husky configurations, ensure the PR focuses only on the essential modifications. good ? @hkirat

@hkirat
Copy link
Contributor

hkirat commented Mar 18, 2024

@devsargam is right, need to be saparate changes
Wholesale lint will probably happen when PRs are at 0 so that people don't have merge conflicts
Can you PR just the eslint changes and remove the automatically generated code?

@TanmayDhobale
Copy link
Contributor Author

@devsargam is right, need to be saparate changes Wholesale lint will probably happen when PRs are at 0 so that people don't have merge conflicts Can you PR just the eslint changes and remove the automatically generated code?

okk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants