Feature: Dynamic Cache Entry Expiry #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkirat
requested changes
Mar 11, 2024
src/db/Cache.ts
Outdated
| new Date().getTime() + | ||
| parseInt(process.env.CACHE_EXPIRE_S || '100', 10) * 1000, | ||
| }); | ||
| set(type: string, args: string[], value: any, expiryInSeconds: number = 3600): void { |
There was a problem hiding this comment.
Should defualt to
new Date().getTime() +
parseInt(process.env.CACHE_EXPIRE_S || '100', 10) * 1000
|
lint seems bonked now |
|
@hkirat ummm significant lint difference could indicate a file was not previously linted according to the current project's linting rules, or the linting configuration has been updated or corrected can u pls check now |
|
/bounty $25 |
|
Let's goooooo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the existing Cache utility by introducing the capability to set dynamic expiry times fvor each cache entry. Previously the cache expiry time was statically set, limiting the utility's flexibility. With this update, users can specify the expiry time in seconds for each set operation, allowing for more nuanced cache control tailored to specific need.