Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persist caption settings in localStorage on track mode change (code100x#1493) #1503

Merged
merged 5 commits into from
Dec 3, 2024
Merged

feat: persist caption settings in localStorage on track mode change (code100x#1493) #1503

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5365c3
feat: persist caption settings in localStorage on track mode change (…
IkramBagban Oct 21, 2024
51422fd
Merge branch 'main' of https://github.com/IkramBagban/cms into featur…
IkramBagban Oct 27, 2024
3d78a6b
Merge branch 'main' of https://github.com/code100x/cms into feature/s…
IkramBagban Nov 7, 2024
7df3d38
Merge branch 'main' of https://github.com/code100x/cms into feature/s…
IkramBagban Nov 12, 2024
0d3ef05
refactor: combine both the with same dependancy
IkramBagban Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 40 additions & 5 deletions src/components/VideoPlayer2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,43 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({
return pipButtonContainer;
};

useEffect(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have 2 useEffects with same dependencies array? Can you add the below login in here only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure

if (!player) return;

const savedCaptionSetting = localStorage.getItem('captionSetting');
const tracks = player.textTracks();

if (savedCaptionSetting && player) {
for (let i = 0; i < tracks.length; i++) {
const track = tracks[i];

if (track) {
track.mode =
savedCaptionSetting === 'showing' ? 'showing' : 'disabled';
}
}
}

const handleTrackChange = () => {
for (let i = 0; i < tracks.length; i++) {
const track = tracks[i];
if (track.kind === 'subtitles' && track.language === 'en') {
track.addEventListener('modechange', () => {
localStorage.setItem('captionSetting', track.mode);
});
}
}
};

handleTrackChange();
return () => {
for (let i = 0; i < tracks.length; i++) {
const track = tracks[i];
track.removeEventListener('modechange', handleTrackChange);
}
};
}, [player]);

useEffect(() => {
const t = searchParams.get('timestamp');
if (contentId && player && !t) {
Expand Down Expand Up @@ -255,11 +292,8 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({
const track = tracks[i];

if (track.kind === 'subtitles' && track.language === 'en') {
if (track.mode === 'hidden') {
track.mode = 'showing';
} else {
track.mode = 'hidden';
}
if (track.mode === 'disabled') track.mode = 'showing';
else track.mode = 'disabled';
}
}
event.stopPropagation();
Expand Down Expand Up @@ -318,6 +352,7 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({
document.removeEventListener('keydown', handleKeyPress);
};
}, [player]);

useEffect(() => {
if (!player) {
return;
Expand Down
Loading