-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connect the questions to the video #1337
Conversation
@siinghd can u look at it in case you are free? |
@ezhil56x looks really good, lets just add two things one minute 1:03 when i click on ask question button it open the modal thats really good! Second: the questions page lets add the possibility to filter questions based on a specific video... maybe add a same search dropdown and when user selects the video only that questions appear |
also fix merge conflicts |
@siinghd Updated my PR with the requested changes 2024-10-06.03-45-33.mp4 |
@siinghd for rereview |
Resolved conflicts. Hoping it to get merged at the earliest to avoid further conflicts. |
hey @devsargam could you please ask Singh Bro to review this one. It's being stalled from a long time. PR looks amazing. |
@avparadox thinking of removing the questions endpoint totally since it is causing many conflicts are not a lot of people are using it a lot |
Maybe we can ask Kirat bro if he wish to take a Quick QnA before every class. If he agrees to it, then maybe PR makes a sense or else I believe it is good to be removed. |
I asked him and he agreed it could be removed but I really like the idea of reading questions present in the QnA area |
Even I liked the QnA page. If people interact, a lot of good content can be seeded like Stackoverflow. But as a dev, we can't control the engagement things. Probably you can declare this as closed. The guy who made this PR, I salute him 🫡. Thanke @ezhil56x 👏🏻 |
@avparadox I agree. |
PR Fixes: #862
Covered all the features proposed in the issue
Linking Questions to Videos
Video Integration
Database Changes
2024-09-28.02-58-56.mp4
Resolves #862
Checklist before requesting a review