Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connect the questions to the video #1337

Closed
wants to merge 10 commits into from

Conversation

ezhil56x
Copy link
Contributor

PR Fixes: #862

Covered all the features proposed in the issue

Linking Questions to Videos

  • While creating a new question users can link a lecture video to it
  • Users can either search for a video or select one from a searchable dropdown menu
  • This feature should be optional, as we still want to allow questions without associated videos.
  • Users can view all questions related to a particular lecture video

Video Integration

  • Each video should have a button that, when clicked, redirects the user to all questions related to that video.

Database Changes

  • Add an optional video_id field to the question table to store the associated video ID.
2024-09-28.02-58-56.mp4

Resolves #862

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@ezhil56x ezhil56x changed the title Questions feat: connect the questions to the video Sep 27, 2024
@devsargam
Copy link
Collaborator

@siinghd can u look at it in case you are free?

@devsargam devsargam requested a review from siinghd September 30, 2024 13:01
@siinghd siinghd mentioned this pull request Oct 4, 2024
2 tasks
@siinghd
Copy link
Collaborator

siinghd commented Oct 4, 2024

@ezhil56x looks really good, lets just add two things

one minute 1:03 when i click on ask question button it open the modal thats really good!
lets add another query parameter, &fromvideo=videoid... this way when the modal opens the video is already there and the user doesnt have to search

Second: the questions page lets add the possibility to filter questions based on a specific video... maybe add a same search dropdown and when user selects the video only that questions appear

@siinghd
Copy link
Collaborator

siinghd commented Oct 4, 2024

also fix merge conflicts

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Oct 5, 2024

@siinghd Updated my PR with the requested changes

2024-10-06.03-45-33.mp4

@devsargam
Copy link
Collaborator

@siinghd for rereview

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Oct 9, 2024

Resolved conflicts. Hoping it to get merged at the earliest to avoid further conflicts.

@avparadox
Copy link
Contributor

hey @devsargam could you please ask Singh Bro to review this one. It's being stalled from a long time. PR looks amazing.

@devsargam
Copy link
Collaborator

@avparadox thinking of removing the questions endpoint totally since it is causing many conflicts are not a lot of people are using it a lot

@avparadox
Copy link
Contributor

Maybe we can ask Kirat bro if he wish to take a Quick QnA before every class. If he agrees to it, then maybe PR makes a sense or else I believe it is good to be removed.

@devsargam
Copy link
Collaborator

I asked him and he agreed it could be removed but I really like the idea of reading questions present in the QnA area

@avparadox
Copy link
Contributor

Even I liked the QnA page. If people interact, a lot of good content can be seeded like Stackoverflow. But as a dev, we can't control the engagement things. Probably you can declare this as closed.

The guy who made this PR, I salute him 🫡.
He have done justice to the issue. I probably can't make such a good PR right now. He has done a commendable job 🙌🏻

Thanke @ezhil56x 👏🏻

@devsargam
Copy link
Collaborator

@avparadox I agree.
@ezhil56x can you give me your upi address I will at least transfer some amount for the effort. Sorry but I can't merge this right now but this is great.

@devsargam devsargam closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Connect the question to the video (High priority - valuable bounty)
4 participants