Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs of questions #1249

Closed
wants to merge 6 commits into from
Closed

Fixes bugs of questions #1249

wants to merge 6 commits into from

Conversation

Zafeeruddin
Copy link
Contributor

@Zafeeruddin Zafeeruddin commented Sep 17, 2024

PR Fixes:

  • 1 Fixes re-rendering of whole page when question is voted on /questions
  • 2 Fixes re-rendering of page when reply is added
  • 3 Fixes re-rendering of page when Editor is clicked

Resolves #1247 #1248

Before:

before.bugs.router.and.re-render.mp4
before.re.render.replies.2.mp4

After:

after.bugs.router.and.re-render.mp4
after.reply.re-render.mp4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

Sorry, something went wrong.

@devsargam
Copy link
Collaborator

Can u open a new pr with minimal changes and less lint changes. Very hard to understand the particular change that you have made.

@devsargam
Copy link
Collaborator

Closing for now. Feel free to reopen

@devsargam devsargam closed this Sep 24, 2024
@Zafeeruddin
Copy link
Contributor Author

@devsargam i am new to this
As soon as I make any changes in any of PRs and fix lint changes, lines which are not touched by me gets changed.
Kindly guide.

  1. I am making lint fixes on fresh branch
  2. 17 files changes (which i didnt changed)
  3. I commit those changes
  4. start working on my issues

Thats why it seems cluttered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Question page is re-rendered when voted
2 participants