Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/signin error handling #1226

Closed

Conversation

Zafeeruddin
Copy link
Contributor

@Zafeeruddin Zafeeruddin commented Sep 15, 2024

PR Fixes:

  • 1 Handles sigin errors better with toasts

Resolves #1225

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@siinghd
Copy link
Collaborator

siinghd commented Sep 16, 2024

@devsargam hold it,

@Zafeeruddin fix lint for " quotes after that we will check

@Zafeeruddin Zafeeruddin force-pushed the feature/SigninErrorHandling branch from 49326c0 to 03eaa61 Compare September 16, 2024 06:07
@Zafeeruddin
Copy link
Contributor Author

Fixed sir @siinghd @devsargam

@devsargam
Copy link
Collaborator

There are so much noise in this pr. Closing for now. Feel free to reopen with minimal changes

@devsargam devsargam closed this Sep 24, 2024
@Zafeeruddin Zafeeruddin mentioned this pull request Sep 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Handling signin errors better using toasts
3 participants