-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: setup docker #122
Feat: setup docker #122
Conversation
@devsargam is attempting to deploy a commit to the My Team Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for charming-semolina-f274cf pending review.Visit the deploys page to approve it
|
@hkirat LMK, if you want any changes. |
@siinghd could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devsargam Optimize the Docker builds by adding a .dockerignore
file.
Can u get rid of the lock file changes? |
Currently in college will do it when I reach home @hkirat |
I think "dev:docker": "DATABASE_URL=postgresql://postgres:postgres@db:5432/cms?schema=public prisma migrate deploy && next dev", this can be improved, looks bit messy. Just my personal opinion |
@siinghd do u have a workaround for it? I didn't find any other way than this hack |
"scripts": {
"prisma:migrate": "prisma migrate deploy",
"dev:docker": "npm run prisma:migrate && next dev"
} in
|
@hkirat this is ready for merge you can go on |
Can we use a single package manager as a source of truth in this repo from now on? Since, doing |
/bounty $50 |
Thanks a lot kirat bhaiya 🙇🏻♀️ |
This pr setups: