add feature to search with Ctrl + k #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuarora700 asked for this feature in your resume roasting video |
|
Can u implement this beautiful library? https://cmdk.paco.me/ |
|
Other than that pr is good |
|
Shadcn commandk internally uses cmdk package. Might as well use that
…On Sun, 15 Sep 2024 at 12:08 AM, Sargam ***@***.***> wrote:
Other than that pr is good
—
Reply to this email directly, view it on GitHub
<#1205 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFRSXFKMBQURMXVJZJSHQ2TZWR7B3AVCNFSM6AAAAABODBC7IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGA4TQNJYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@devsargam added shadcn commandk component |
|
@devsargam any other feedback? |
|
Let me check this pr by eod |
|
|
lol sorry sir |
devsargam
requested changes
Sep 23, 2024
src/components/search/SearchBar.tsx
Outdated
| const handleKeyPress = (event: KeyboardEvent) => { | ||
| switch (event.code) { | ||
| case 'KeyK': | ||
| if (event.ctrlKey) { |
There was a problem hiding this comment.
You are just checking with ctrl key but as the name suggests it should also support ⌘K on mac
devsargam
requested changes
Sep 23, 2024
devsargam
requested changes
Sep 23, 2024
devsargam
requested changes
Sep 23, 2024
2 tasks
|
Added cmd K for MacOs also |
|
can u flix conflicts @AuenKr? |
3 tasks
|
@devsargam resolves the conflict. |
|
@devsargam, any other change required? |
|
Let me rereview it |
|
@devsargam ?? |
|
yeah yeah it's all good #1270 just want to see what's this got |
|
Thank u |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Before:
ctrlBefore.mp4
After:
2024-09-12_16-53-59.mp4
Checklist before requesting a review