Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds active menu highlight on sidebar && fixes few minor UI bugs #1170

Closed

Conversation

hxdy-1
Copy link
Contributor

@hxdy-1 hxdy-1 commented Sep 9, 2024

PR Fixes:

  • Adds highlight stylings for the active menu even on nested routes which wasn't there previously that is right after the new UI revamp (look at the url and sidebar in the below ss)
    image

  • Brings the sidebar closed icon in center, which was not justified earlier (it is in the center now)
    image

  • Add bg color to the course content sidebar so that it's text doesn't appear overlapped
    image

Resolves #1028
Resolves #1167

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

Copy link

@SadatHussain7 SadatHussain7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devsargam devsargam closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants