Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust z-index for improved search results visibility (#1082) #1086

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix: Adjust z-index for improved search results visibility (#1082) #1086

merged 3 commits into from
Aug 30, 2024

Conversation

csgaikwad
Copy link
Contributor

PR Fixes: Resolves #1082

Issue Description

The search results are not fully visible as they are being blocked by course content due to incorrect z-index values.

Changes Made

  • Increased z-index from z-10 to z-30 for search results
  • The z-index of course content is z-20

Before

image

After

image

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@csgaikwad csgaikwad mentioned this pull request Aug 30, 2024
Closed
@siinghd
Copy link
Collaborator

siinghd commented Aug 30, 2024

thank you sir

@siinghd siinghd merged commit 10309e6 into code100x:main Aug 30, 2024
1 check failed
@csgaikwad
Copy link
Contributor Author

csgaikwad commented Aug 30, 2024 •
edited
Loading

thank you sir

No, Thank you Sir !
and why is there a check failed do i need to worry about that? @siinghd
is this because of pnpm as mentioned here?

Screenshot 2024-08-30 190959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

style: Search results hidden by course content
2 participants
@csgaikwad @siinghd