Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made sidebar Header Sticky #1085

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

zenithexe
Copy link
Contributor

PR Fixes:

  • 1 Made the Content Sidebar Heading Sticky

Resolves #1084

sidebar-sticky.mp4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@csgaikwad
Copy link
Contributor

Are you working on the failed checks?

@zenithexe
Copy link
Contributor Author

zenithexe commented Aug 30, 2024

I have been trying to solve the failed check for quite some time now, from what I have realized, I think something is broken in the main repo itself. When I try to clone and install(npm i) the code100x/cms repo, it gives the same error.

Also, as you can see I have made changes only to the Sidebar.tsx file.

@hkirat @devsargam you guys should look into this.

@devsargam
Copy link
Collaborator

Np it's a conflict between husky and prettier u don't need to worry

@csgaikwad
Copy link
Contributor

csgaikwad commented Aug 30, 2024

When I try to clone and install(npm i) the code100x/cms repo, it gives the same error.

I feel like we are supposed to use pnpm install rather than npm i and if so they should update the installation docs

While using npm i got errors everywhere even if i use --force and while using pnpm i db:seed everything went smoothly
So i am asking if we are supposed to use pnpm? @devsargam

@csgaikwad
Copy link
Contributor

csgaikwad commented Aug 30, 2024

@zenithexe they are saying don't use npm as they are trying to migrate to pnpm

@siinghd
Copy link
Collaborator

siinghd commented Aug 30, 2024

thank you sir

@siinghd siinghd merged commit 0966fa1 into code100x:main Aug 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style: Fix title "course content" to stick to the top.
4 participants