Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sidebar remaining open #1048

Closed
wants to merge 3 commits into from

Conversation

zenithexe
Copy link
Contributor

PR Fixes:

  • 1 The state of the main sidebar is made consistent.
  • 2 Implemented a global state variable instead of the a local state variable to open and close the sidebar.

Resolves #1044

Sidebar.Issue.mp4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@Azathoth-11
Copy link

PR Fixes:

  • 1 The state of the main sidebar is made consistent.
  • 2 Implemented a global state variable instead of the a local state variable to open and close the sidebar.

Resolves #1044

Sidebar.Issue.mp4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

what about when there is the refresh database button? will be still collapse?

@zenithexe
Copy link
Contributor Author

@Azathoth-11 You were right, since the Refresh Database button was added later, it wasn't integrated with the state variable.
I have fixed that in my new commit.

@devsargam devsargam closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: sidebar remaining open
3 participants