Feat: Chess Mobile App with authentication #347
Conversation
…into feat/mobile-app
| import { db } from '../db'; | ||
| import base64 from 'base-64'; |
There was a problem hiding this comment.
Can Use JWT also, but it'll be two times longer than base64 encode token and also it needs a secret too.
Can shift to JWT there's no problem
| @@ -60,11 +63,29 @@ router.get( | |||
| router.get( | |||
| '/google/callback', | |||
| passport.authenticate('google', { | |||
| successRedirect: CLIENT_URL, | |||
| // successRedirect: CLIENT_URL, | |||
There was a problem hiding this comment.
why we only comment this here and not on github or facebook too?
There was a problem hiding this comment.
Only tested for google, I'll update it after testing for github and facebook
Yess I have tested it, let me find a way to provide a APK to test this |
| import { db } from '../db'; | ||
| import base64 from 'base-64'; |
There was a problem hiding this comment.
Can Use JWT also, but it'll be two times longer than base64 encode token and also it needs a secret too.
Can shift to JWT there's no problem
|
lets go with jwt... also send an apk please |
Ohk I'll shift to jwt, and regarding apk, I am figuring out why it's not working in production but working perfectly fine in development mode |
|
@siinghd expo doesn't have jwt support as jwt requires node internal library crypto so I kept the base64 and made the apk For the time being I hosted web socket server and backend server to ec2 and postgres is running on neon db |
|
🎉 🎉 🎉 |
|
@ofcljaved thank you will test it later |
|
Lol |
This PR do this
https://youtu.be/-6WtZn5Zx0I
In order to have same backend for mobile and app, I added another callback which will capture the cookie and send it as query params for mobile and works exactly same for web
Full documentation is in README