Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mediasoup for WebRTC calls #334

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Ruchir28
Copy link
Contributor

No description provided.

@Ruchir28 Ruchir28 marked this pull request as ready for review May 25, 2024 10:56
@nimit9
Copy link
Contributor

nimit9 commented May 25, 2024

Have done this in #315

Would love to know if you have added something extra which I missed.

@Ruchir28
Copy link
Contributor Author

Ruchir28 commented May 26, 2024

Skimmed through your PR, and here are some differences I noticed:

This one's

1.	Handling n number of users in a room.
2.	Support for both video and audio.
3.	Worker management: workers run on CPU cores and handle multiple routers, 
created initially based on CPU cores, and typically shouldn’t be one per user.
4.	Design differences.

Let me know your thoughts!

@nimit9
Copy link
Contributor

nimit9 commented May 26, 2024

  1. Since two players would be playing the game, only they need to connect over a video call, adding extra users is not needed atm.

  2. Yes, I have to add audio as well, it skipped my mind

  3. Will read about it more.

  4. Due to implementation differences, yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants