Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brush up CI #75

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Brush up CI #75

merged 6 commits into from
Jul 17, 2024

Conversation

cmarqu
Copy link
Contributor

@cmarqu cmarqu commented Mar 1, 2024

Make CI setup work again (but not actually pass, because of #62).

Do not run CI on both push and PR.
Use latest version of actions.
Iterate over oldest and newest supported Python versions.
Iterate over oldest and newest supported cocotb versions.
Use color output for cocotb tests.

@cmarqu cmarqu force-pushed the fix/ci branch 10 times, most recently from d59359e to e8a7630 Compare March 1, 2024 16:57
@cmarqu cmarqu force-pushed the fix/ci branch 9 times, most recently from a0c8c09 to e2826a9 Compare March 1, 2024 20:10
@cmarqu cmarqu changed the title Fix CI fails Brush up CI Mar 1, 2024
Do not run CI on both push and PR.
Use latest version of actions.
Iterate over oldest and newest supported Python versions.
Iterate over oldest and newest supported cocotb versions.
Use color output for cocotb tests.
@cmarqu cmarqu marked this pull request as ready for review March 1, 2024 20:18
@cmarqu cmarqu requested a review from ktbarrett March 1, 2024 20:18
@cmarqu cmarqu closed this Jul 17, 2024
@cmarqu cmarqu reopened this Jul 17, 2024
@ktbarrett
Copy link
Member

Okay. It's running, but failing. Is that okay for now @cmarqu? The issue may have to do with cleaning up the cocotb.forks.

@cmarqu
Copy link
Contributor Author

cmarqu commented Jul 17, 2024

Okay. It's running, but failing. Is that okay for now @cmarqu? The issue may have to do with cleaning up the cocotb.forks.

Yes, I wanted to have CI run before I work on #62. Thanks for the review!

@cmarqu cmarqu merged commit 0c99b54 into master Jul 17, 2024
3 of 5 checks passed
@cmarqu cmarqu deleted the fix/ci branch July 17, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants