Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further link reference in LDR docs #19240

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

kathancox
Copy link
Contributor

Fixes DOC-11689

This PR adds a handful more link references between LDR (and PCR) pages.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit d737648
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6764322889715d0008f34f7d

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit d737648
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6764322878d4590008584312


LDR supports starting with two empty tables, or one non-empty table. LDR does **not** support starting with two non-empty tables. When you set up bidirectional LDR, if you're starting with one non-empty table, start the first LDR job from empty to non-empty table. Therefore, you would run `CREATE LOGICAL REPLICATION STREAM` from the destination cluster where the non-empty table exists.

## Examples

To start LDR, you must run the `CREATE LOGICAL REPLICATION STREAM` statement from the **destination** cluster. Use the[ fully qualified table name(s)]({% link {{ page.version.version }}/sql-name-resolution.md %}#how-name-resolution-works) and ensure that the source and destination table names are identical. The following examples show statement usage with different options and use cases.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the identical table names clause here is coming out because in the first round of ldr reviews I had got this wrong and an engineer corrected; however I forgot to remove this from the SQL ref page too.

Copy link

netlify bot commented Dec 16, 2024

Netlify Preview

Name Link
🔨 Latest commit d737648
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6764322877a80b00086ec46a
😎 Deploy Preview https://deploy-preview-19240--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathancox kathancox requested a review from rmloveland December 16, 2024 16:01
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kathancox kathancox force-pushed the cross-links-ldr-resilience branch from aa3d8f2 to d737648 Compare December 19, 2024 14:48
@kathancox kathancox merged commit 5c53a21 into main Dec 19, 2024
6 checks passed
@kathancox kathancox deleted the cross-links-ldr-resilience branch December 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants