[DOC-11431][DOC-10454] Document admission control for snapshot ingestion #19068

mdlinville · 2024-10-30T17:13:26Z

[DOC-11431] Document admission control for snapshot ingestion
[DOC-10454] Docs for ac: disk bandwidth accounting

github-actions · 2024-10-30T17:13:50Z

Files changed:

netlify · 2024-10-30T17:13:58Z

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name	Link
🔨 Latest commit	`8916ae9`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-api-docs/deploys/673392d6734a200008131d18

netlify · 2024-10-30T17:14:02Z

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name	Link
🔨 Latest commit	`8916ae9`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/673392d66d9337000819deba

netlify · 2024-10-30T17:14:34Z

✅ Netlify Preview

Name	Link
🔨 Latest commit	`8916ae9`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/673392d6ed995c0008b9e391
😎 Deploy Preview	https://deploy-preview-19068--cockroachdb-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/current/v24.3/admission-control.md

dshjoshi · 2024-11-06T19:12:56Z

@rmloveland

4th bullet in this section https://deploy-preview-19068--cockroachdb-docs.netlify.app/docs/v24.3/admission-control.html#enable-and-disable-admission-control Should say "Preview in 24.3"
Also add 5th bullet in the same section
"Preview in 24.3" kvadmission.store.provisioned_bandwidth, if set to a non-zero value, this is used as the provisioned bandwidth (in bytes/s), to enable disk bandwidth based admission control, since admission.disk_bandwidth_tokens.elastic.enabled defaults to true.
Also there is font size formatting issue with the last bullet (intent resolution) in this section https://deploy-preview-19068--cockroachdb-docs.netlify.app/docs/v24.3/admission-control.html#operations-subject-to-admission-control

- Add missing cluster setting kvadmission.store.provisioned_bandwidth - Add snapshot ingestion and provisioned bandwidth to Feature Availability - Fix stray bullet causing rendering errors

mdlinville · 2024-11-06T21:07:32Z

@rmloveland

4th bullet in this section https://deploy-preview-19068--cockroachdb-docs.netlify.app/docs/v24.3/admission-control.html#enable-and-disable-admission-control Should say "Preview in 24.3"

Also add 5th bullet in the same section
"Preview in 24.3" kvadmission.store.provisioned_bandwidth, if set to a non-zero value, this is used as the provisioned bandwidth (in bytes/s), to enable disk bandwidth based admission control, since admission.disk_bandwidth_tokens.elastic.enabled defaults to true.

Also there is font size formatting issue with the last bullet (intent resolution) in this section https://deploy-preview-19068--cockroachdb-docs.netlify.app/docs/v24.3/admission-control.html#operations-subject-to-admission-control

Done. The missed setting is not marked as New in v24.3.

src/current/v24.3/admission-control.md

src/current/v24.3/cockroachdb-feature-availability.md

mdlinville · 2024-11-08T20:15:49Z

@rmloveland

4th bullet in this section https://deploy-preview-19068--cockroachdb-docs.netlify.app/docs/v24.3/admission-control.html#enable-and-disable-admission-control Should say "Preview in 24.3"

Also add 5th bullet in the same section
"Preview in 24.3" kvadmission.store.provisioned_bandwidth, if set to a non-zero value, this is used as the provisioned bandwidth (in bytes/s), to enable disk bandwidth based admission control, since admission.disk_bandwidth_tokens.elastic.enabled defaults to true.

Also there is font size formatting issue with the last bullet (intent resolution) in this section https://deploy-preview-19068--cockroachdb-docs.netlify.app/docs/v24.3/admission-control.html#operations-subject-to-admission-control

Done. The missed setting is not marked as New in v24.3.

@dshjoshi Is this looking good with the latest changes?

rmloveland

LGTM thank you Matt for taking this on!!!!

found a couple small non-blocking things, a typo and a missing sentence clause

src/current/v24.3/architecture/replication-layer.md

src/current/v24.3/cockroachdb-feature-availability.md

mdlinville requested a review from rmloveland October 30, 2024 17:13

[DOC-11431] Document admission control for snapshot ingestion

176f8cb

mdlinville force-pushed the DOC-11431 branch from 65b34ed to 176f8cb Compare October 30, 2024 17:19

mdlinville commented Oct 30, 2024

View reviewed changes

src/current/v24.3/admission-control.md Show resolved Hide resolved

rmloveland requested review from dshjoshi and aadityasondhi October 30, 2024 19:13

mdlinville changed the title ~~[DOC-11431] Document admission control for snapshot ingestion~~ [DOC-11431][DOC-10454] Document admission control for snapshot ingestion Oct 30, 2024

mdlinville added 6 commits October 30, 2024 15:35

Merge branch 'main' into DOC-11431

35527a1

Merge branch 'main' into DOC-11431

daf1b16

Merge branch 'main' into DOC-11431

942408d

Merge branch 'main' into DOC-11431

7941bd2

Merge branch 'main' into DOC-11431

8a8a334

Merge branch 'main' into DOC-11431

6658c5f

aadityasondhi reviewed Nov 6, 2024

View reviewed changes

src/current/v24.3/admission-control.md Outdated Show resolved Hide resolved

mdlinville commented Nov 6, 2024

View reviewed changes

src/current/v24.3/admission-control.md Outdated Show resolved Hide resolved

mdlinville added 2 commits November 6, 2024 09:41

Update src/current/v24.3/admission-control.md

4d3f899

Merge branch 'main' into DOC-11431

6e37570

mdlinville requested a review from aadityasondhi November 6, 2024 17:42

Merge branch 'main' into DOC-11431

e4a92bc

mdlinville added 2 commits November 6, 2024 12:23

Merge branch 'main' into DOC-11431

bbc9db1

Address feedback

ec23e18

- Add missing cluster setting kvadmission.store.provisioned_bandwidth - Add snapshot ingestion and provisioned bandwidth to Feature Availability - Fix stray bullet causing rendering errors

mdlinville added 2 commits November 6, 2024 13:07

Merge branch 'main' into DOC-11431

ca87957

Merge branch 'main' into DOC-11431

56c1b34

mdlinville commented Nov 7, 2024

View reviewed changes

src/current/v24.3/admission-control.md Outdated Show resolved Hide resolved

src/current/v24.3/cockroachdb-feature-availability.md Outdated Show resolved Hide resolved

mdlinville added 3 commits November 7, 2024 12:28

Apply suggestions from code review

4251d43

Merge branch 'main' into DOC-11431

f38d82d

Merge branch 'main' into DOC-11431

dfff1d3

aadityasondhi approved these changes Nov 8, 2024

View reviewed changes

mdlinville added 2 commits November 8, 2024 12:15

Merge branch 'main' into DOC-11431

fe0f61d

Merge branch 'main' into DOC-11431

5430b5f

rmloveland approved these changes Nov 12, 2024

View reviewed changes

src/current/v24.3/architecture/replication-layer.md Outdated Show resolved Hide resolved

src/current/v24.3/cockroachdb-feature-availability.md Outdated Show resolved Hide resolved

mdlinville added 3 commits November 12, 2024 09:31

Merge remote-tracking branch 'origin/main' into DOC-11431

02980b4

Rich's feedback

4c4e37c

Merge remote-tracking branch 'origin/DOC-11431' into DOC-11431

8916ae9

mdlinville requested a review from rmloveland November 12, 2024 17:39

mdlinville merged commit c63cb12 into main Nov 12, 2024
6 checks passed

mdlinville deleted the DOC-11431 branch November 12, 2024 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DOC-11431][DOC-10454] Document admission control for snapshot ingestion #19068

[DOC-11431][DOC-10454] Document admission control for snapshot ingestion #19068

mdlinville commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

dshjoshi commented Nov 6, 2024 •

edited

Loading

mdlinville commented Nov 6, 2024

mdlinville commented Nov 8, 2024

rmloveland left a comment

[DOC-11431][DOC-10454] Document admission control for snapshot ingestion #19068

[DOC-11431][DOC-10454] Document admission control for snapshot ingestion #19068

Conversation

mdlinville commented Oct 30, 2024 • edited Loading

github-actions bot commented Oct 30, 2024 • edited Loading

Files changed:

netlify bot commented Oct 30, 2024 • edited Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

netlify bot commented Oct 30, 2024 • edited Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

netlify bot commented Oct 30, 2024 • edited Loading

✅ Netlify Preview

dshjoshi commented Nov 6, 2024 • edited Loading

mdlinville commented Nov 6, 2024

mdlinville commented Nov 8, 2024

rmloveland left a comment

Choose a reason for hiding this comment

mdlinville commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

dshjoshi commented Nov 6, 2024 •

edited

Loading