Azure blob storage: Correct scheme prefix to azure-blob:// #17939

benbardin · 2023-09-28T18:49:32Z

No description provided.

netlify · 2023-09-28T18:49:55Z

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name	Link
🔨 Latest commit	`df5ba0c`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6515cabf3564b300088da9d8

netlify · 2023-09-28T18:49:56Z

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name	Link
🔨 Latest commit	`df5ba0c`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6515cabf2ddf7200088071e4

netlify · 2023-09-28T18:50:11Z

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name	Link
🔨 Latest commit	`3802fbf`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/65a1b26ed9b3730009ace8dc

netlify · 2023-09-28T18:50:12Z

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name	Link
🔨 Latest commit	`3802fbf`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-api-docs/deploys/65a1b26eaf8d5600084b33af

mdlinville

Just a tiny nit.

src/current/v22.2/cloud-storage-authentication.md

src/current/v23.1/cloud-storage-authentication.md

netlify · 2023-09-28T18:52:17Z

✅ Netlify Preview

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`df5ba0c`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/6515cabf6003200008cb4e07
😎 Deploy Preview	https://deploy-preview-17939--cockroachdb-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-09-28T18:55:32Z

✅ Netlify Preview

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`3802fbf`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/65a1b26e1c4ee00008061d81
😎 Deploy Preview	https://deploy-preview-17939--cockroachdb-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

benbardin · 2023-09-28T19:07:53Z

Thanks! I'll just wait for Yevgeniy to double-check I didn't get the CDC stuff wrong.

…

On Thu, Sep 28, 2023 at 2:55 PM netlify[bot] ***@***.***> wrote: ✅ Netlify Preview Built without sensitive environment variables <https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy> Name Link 🔨 Latest commit 4ce6a62 <4ce6a62> 🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6515cacb6ddbd10008690f99 😎 Deploy Preview https://deploy-preview-17939--cockroachdb-docs.netlify.app 📱 Preview on mobile Toggle QR Code... [image: QR Code] <https://camo.githubusercontent.com/6e25e7b121b0df50433204dc2d194af425e9f6634bf0510528006b223c53851e/68747470733a2f2f6170702e6e65746c6966792e636f6d2f71722d636f64652f65794a30655841694f694a4b563151694c434a68624763694f694a49557a49314e694a392e65794a31636d77694f694a6f64485277637a6f764c32526c6347787665533177636d5632615756334c5445334f544d354c53316a62324e72636d39685932686b5969316b62324e7a4c6d356c644778705a6e6b7559584277496e302e4b695f596a3947394e784e683657495851414b414771666f6f2d6d626f70576551716a72524577654d4e41> *Use your smartphone camera to open QR code link.* ------------------------------ *To edit notification comments on pull requests, go to your Netlify site configuration <https://app.netlify.com/sites/cockroachdb-docs/configuration/deploys#deploy-notifications>.* — Reply to this email directly, view it on GitHub <#17939 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB73BEAV5GKH26PQPBNPQTX4XB27ANCNFSM6AAAAAA5LM6AYM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

kathancox · 2023-09-28T19:59:37Z

@benbardin azure-blob hasn't yet been added as a supported scheme for external connections?

benbardin · 2023-09-28T20:27:46Z

It shipped with 23.1 AFAIK, but we didn't update the docs. I just backported it to 22.2 as well.

kathancox · 2023-09-28T21:37:43Z

It shipped with 23.1 AFAIK, but we didn't update the docs. I just backported it to 22.2 as well.

OK, cool, I will wait to see an auto-gen'd docs issue for that then

Co-authored-by: Matt Linville (he/him) <[email protected]>

kathancox · 2024-01-12T20:56:00Z

@benbardin I made some more updates to this. At the same time, I tested on azure-blob with a backup, changefeed, and external connection on v23.1 and v22.2. All good on v23.1. In v22.2, I'm getting unsupported sink when trying to create a changefeed.

benbardin · 2024-01-12T21:29:09Z

Whelp, sounds like I did indeed get the CDC stuff wrong. As 22.2 is now EOL, though, maybe we just leave it alone?

kathancox · 2024-01-12T21:31:23Z

Whelp, sounds like I did indeed get the CDC stuff wrong. As 22.2 is now EOL, though, maybe we just leave it alone?

Yes, we can totally do that. I will remove that from the PR and then get this merged.

benbardin · 2024-01-12T21:33:31Z

Thank you! Sorry for the trouble!

kathancox · 2024-01-12T21:44:28Z

src/current/_includes/releases/v22.2/v22.2.15.md

@@ -35,7 +35,6 @@ Release Date: October 23, 2023
 - When upgrading from previous releases, it was possible that ambiguous references to [sequences](https://www.cockroachlabs.com/docs/v22.2/create-sequence) would fail to be resolved by ID if they were in the same schema. Additionally, the logging is improved for ambiguous cases where the reference cannot be resolved. [#110721][#110721]
 - Fixed a bug where [`RESET `](https://www.cockroachlabs.com/docs/v22.2/row-level-ttl#reset-a-storage-parameter-to-its-default-value)[(`ttl_expire_after`)](https://www.cockroachlabs.com/docs/v22.2/row-level-ttl#using-ttl_expire_after) could incorrectly remove [`ttl_expiration_expression`](https://www.cockroachlabs.com/docs/v22.2/row-level-ttl#using-ttl_expiration_expression). [#110750][#110750]
 - Fixed a bug where [`format_type`](https://www.cockroachlabs.com/docs/v22.2/functions-and-operators#compatibility-functions) builtin did not honor `typemod` information for [array](https://www.cockroachlabs.com/docs/v22.2/array) types, leading to incorrect output. [#110939][#110939]
- External connection URLs now accept the scheme `azure-blob` for connections to [Azure](https://www.cockroachlabs.com/docs/v22.2/use-cloud-storage#url-format) Blob Storage. For backward compatibility, schemes `azure` and `azure-storage` schemes continue to work for connections to Azure Blob Storage. [#111286][#111286]


Removing from here so that users of v22.2 do not use an external connection holding an azure-blob scheme expecting it to work with changefeeds.

kathancox · 2024-01-12T21:49:46Z

@benbardin Thank you for creating the PR in the first place!

benbardin requested review from mdlinville and miretskiy September 28, 2023 18:49

mdlinville approved these changes Sep 28, 2023

View reviewed changes

src/current/v22.2/cloud-storage-authentication.md Outdated Show resolved Hide resolved

src/current/v23.1/cloud-storage-authentication.md Outdated Show resolved Hide resolved

benbardin and others added 3 commits January 12, 2024 15:17

Azure blob storage: Correct scheme prefix to azure-blob://

c3c355e

Apply suggestions from code review

ae25d61

Co-authored-by: Matt Linville (he/him) <[email protected]>

Additional changes for v23.2 docs and other missing places

4345143

kathancox force-pushed the azure-storage-2 branch from 1ed70cc to 4345143 Compare January 12, 2024 20:43

kathancox added 2 commits January 12, 2024 16:37

Remove v22.2

32a7b1f

More v22.2 changes

3802fbf

kathancox reviewed Jan 12, 2024

View reviewed changes

kathancox merged commit 1b340cd into cockroachdb:main Jan 12, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure blob storage: Correct scheme prefix to azure-blob:// #17939

Azure blob storage: Correct scheme prefix to azure-blob:// #17939

benbardin commented Sep 28, 2023

netlify bot commented Sep 28, 2023

netlify bot commented Sep 28, 2023

netlify bot commented Sep 28, 2023 •

edited

Loading

netlify bot commented Sep 28, 2023 •

edited

Loading

mdlinville left a comment

netlify bot commented Sep 28, 2023

netlify bot commented Sep 28, 2023 •

edited

Loading

benbardin commented Sep 28, 2023 via email

kathancox commented Sep 28, 2023

benbardin commented Sep 28, 2023

kathancox commented Sep 28, 2023

kathancox commented Jan 12, 2024

benbardin commented Jan 12, 2024

kathancox commented Jan 12, 2024

benbardin commented Jan 12, 2024

kathancox Jan 12, 2024

kathancox commented Jan 12, 2024

Azure blob storage: Correct scheme prefix to azure-blob:// #17939

Azure blob storage: Correct scheme prefix to azure-blob:// #17939

Conversation

benbardin commented Sep 28, 2023

netlify bot commented Sep 28, 2023

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

netlify bot commented Sep 28, 2023

✅ Deploy Preview for cockroachdb-api-docs canceled.

netlify bot commented Sep 28, 2023 • edited Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

netlify bot commented Sep 28, 2023 • edited Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

mdlinville left a comment

Choose a reason for hiding this comment

netlify bot commented Sep 28, 2023

✅ Netlify Preview

netlify bot commented Sep 28, 2023 • edited Loading

✅ Netlify Preview

benbardin commented Sep 28, 2023 via email

kathancox commented Sep 28, 2023

benbardin commented Sep 28, 2023

kathancox commented Sep 28, 2023

kathancox commented Jan 12, 2024

benbardin commented Jan 12, 2024

kathancox commented Jan 12, 2024

benbardin commented Jan 12, 2024

kathancox Jan 12, 2024

Choose a reason for hiding this comment

kathancox commented Jan 12, 2024

netlify bot commented Sep 28, 2023 •

edited

Loading

netlify bot commented Sep 28, 2023 •

edited

Loading

netlify bot commented Sep 28, 2023 •

edited

Loading