Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mr serverless ga #17907

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Mr serverless ga #17907

merged 12 commits into from
Sep 29, 2023

Conversation

gemma-shay
Copy link
Contributor

@gemma-shay gemma-shay commented Sep 21, 2023 •
edited
Loading

https://cockroachlabs.atlassian.net/browse/DOC-7040
https://cockroachlabs.atlassian.net/browse/DOC-6774
Update MR serverless docs from preview to GA
Account for cross-region networking charges

@github-actions
Copy link

github-actions bot commented Sep 21, 2023 •
edited
Loading

Files changed:

@netlify
Copy link

netlify bot commented Sep 21, 2023 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit a598470
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/65174cf9774a810008280d76

@netlify
Copy link

netlify bot commented Sep 21, 2023 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit a598470
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/65174cf93e5d330007bb2853

@netlify
Copy link

netlify bot commented Sep 21, 2023 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit a598470
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/65174cf9dc930700080c948d
😎 Deploy Preview https://deploy-preview-17907--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marksoper
marksoper approved these changes Sep 26, 2023
View reviewed changes
Copy link

@marksoper marksoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 suggestion.

mdlinville
mdlinville approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few optional suggestions.

src/current/cockroachcloud/plan-your-cluster-serverless.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/plan-your-cluster-serverless.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/plan-your-cluster-serverless.md Show resolved Hide resolved
src/current/cockroachcloud/serverless-resource-usage.md Outdated Show resolved Hide resolved
@gemma-shay gemma-shay enabled auto-merge (squash) September 29, 2023 22:17
@gemma-shay gemma-shay merged commit 02b0ccc into main Sep 29, 2023
3 checks passed
@gemma-shay gemma-shay deleted the mr-serverless-ga branch September 29, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlinville mdlinville mdlinville approved these changes

@marksoper marksoper marksoper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gemma-shay @marksoper @mdlinville